Better cleanup for functions sliding data in #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DenisYaroshevskiy current implementation generates a logical mask from What's your opinion? |
After discussion, we can use slide_right |
jfalcou
force-pushed
the
fix-667/better-cleanup
branch
from
3093978 to
c50e4f5
Compare
DenisYaroshevskiy
approved these changes
Jun 30, 2022
jtlap
pushed a commit
that referenced
this pull request
May 12, 2024
* Better cleanup for slide_left * Factorize sum style cleanup into remove_garbage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some functions used a bad cleanup and slide_left somehow forgot to get cleaned up properly.
This fix #667 and clear up the issue raised by the latest tests rewrite on unary slide_left.