Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typesafe testSaga & expectSaga #270

Merged
merged 1 commit into from
Aug 5, 2019
Merged

Conversation

ghost
Copy link

@ghost ghost commented Apr 21, 2019

When used with typescript, I saw that testSaga and expectSaga functions were not typesafe with their parameters.

Just used the power of typescript generics to fix that :)

@codecov-io
Copy link

codecov-io commented Apr 21, 2019

Codecov Report

Merging #270 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #270   +/-   ##
=======================================
  Coverage   99.59%   99.59%           
=======================================
  Files          22       22           
  Lines         744      744           
  Branches      153      153           
=======================================
  Hits          741      741           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9762103...1da72a6. Read the comment docs.

@META-DREAMER
Copy link

META-DREAMER commented Aug 1, 2019

@jfairbank @jp928 It would be incredibly useful if this could be merged. Could you have a look please?

@jp928 jp928 merged commit ed6b1aa into jfairbank:master Aug 5, 2019
@jp928
Copy link
Collaborator

jp928 commented Aug 5, 2019

@HammadJ @TheryFouchter Thanks for your contribution. This pull request has been merged.

@META-DREAMER
Copy link

@jp928 any idea when we could expect this to be released to NPM?

@jp928
Copy link
Collaborator

jp928 commented Aug 8, 2019

@HammadJ Thanks for your contribution. The 4.0.0-beta4 has been released.

@META-DREAMER
Copy link

@jp928 We are still using redux-saga 0.16.2, but 4.0.0 is only comparable with redux-saga > 1. Is there any chance you could release a patch for [email protected] with this change? Can release it as 3.7.1, or 3.8.0 to prevent people getting type errors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants