Issue #9906 Empty path info #9907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olamy
requested changes
Jun 15, 2023
...tty-ee10-servlet/src/test/java/org/eclipse/jetty/ee10/servlet/ServletContextHandlerTest.java
Outdated
Show resolved
Hide resolved
...jetty-ee9-servlet/src/test/java/org/eclipse/jetty/ee9/servlet/ServletContextHandlerTest.java
Outdated
Show resolved
Hide resolved
…ee10/servlet/ServletContextHandlerTest.java Co-authored-by: Olivier Lamy <[email protected]>
…9/servlet/ServletContextHandlerTest.java Co-authored-by: Olivier Lamy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9906
When using
ContextHandler.setAllowNullPathInfo(true)a URL like/ctxis not redirected to/ctx/. In older versions of jetty, the resulting path in context of""is forced to be/and is thus sent on to whatever servlet matches that (usually the default servlet). In jetty-12 we do not fake the path to be/and we were returning a404.This PR allows the path in context of
""to match the same servlet as does a path in context of/.However, unlike previous versions of jetty, we do not force the path in context to be
/, the path in context will continue to be"". To do the forcing would impose extra processing on the critical path of handling a request that isn't justified by this edge-case. If skipping the redirect of/ctxto/ctx/is desired and the application wants the path in context to be/, then theRewriteHandlercan be used to rewrite/ctxto/ctx/before the request hits theServletContextHandler.