Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util: Add support for GraalVM Native-Image resource:-URIs and Paths #9136
util: Add support for GraalVM Native-Image resource:-URIs and Paths #9136
Changes from 1 commit
b53e7e0
41c80b1
7105561
b5dabf9
ac1592e
0bb9d16
a5011d1
c74ad3c
8d0d327
30ffbcb
cdea111
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shall not be automatic or defaulted.
The modifications you have made to
URIUtil
andPathResource
should be refactored out into a standaloneGraalVMResourceFactory
implementation, not by modifying the default behaviors.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've thought about that, but then GraalVM-unaware code that simply tries to serve resources from the classpath will fail.
I've amended my change to transparently support the following real-world use case:
The new change only enables "resource:" URLs when a well-known GraalvM Native Image system property is set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can go one of two ways: