Issue #8895 - Introduce jetty-home-<ver>-with-docs.zip
#8898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joakim Erdfelt <[email protected]>
|
This isn't 100% ready (yet). |
|
The output ... |
|
Doesn't lengthen the build appreciably, seems fine. |
jmcc0nn3ll
reviewed
Nov 14, 2022
olamy
reviewed
Nov 14, 2022
|
sounds good. |
Now the jetty-home artifact builds at the right time in the reactor. Signed-off-by: Joakim Erdfelt <[email protected]>
+ Fix for circular dependency loop
test-distribution ->
jetty-home ->
jetty-documentation ->
jetty-asciidoctor-extensions ->
test-distribution
+ Remove any deps on anything in org.eclipse.jetty from new module
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
olamy
reviewed
Nov 16, 2022
tests/jetty-home-tester/src/main/java/org/eclipse/jetty/tests/hometester/JettyHomeTester.java
Outdated
Show resolved
Hide resolved
|
doh looks to be some chicken and eggs problem to solve here :) |
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
…tility' into fix/jetty-10-home-with-docs # Conflicts: # tests/jetty-home-tester/src/main/java/org/eclipse/jetty/tests/hometester/JettyHomeTester.java
Signed-off-by: Joakim Erdfelt <[email protected]>
joakime
commented
Nov 16, 2022
| @@ -252,14 +252,18 @@ | |||
| <artifactId>jetty-slf4j-impl</artifactId> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
| <!--<dependency> | |||
| <groupId>org.eclipse.jetty</groupId> | |||
| <artifactId>jetty-home</artifactId> | |||
There was a problem hiding this comment.
@olamy do you recall why is this dependency here?
When I comment it out, the plugin still works (and tests properly).
There was a problem hiding this comment.
I'll just delete it.
There was a problem hiding this comment.
Because jetty-maven-plugin depends on it (see https://github.com/eclipse/jetty.project/blob/3569f6506618f0a4d95f76b72979cc0548cc6a42/jetty-maven-plugin/src/main/java/org/eclipse/jetty/maven/plugin/AbstractWebAppMojo.java#L68 and https://github.com/eclipse/jetty.project/blob/3569f6506618f0a4d95f76b72979cc0548cc6a42/jetty-maven-plugin/src/main/java/org/eclipse/jetty/maven/plugin/AbstractWebAppMojo.java#L557) there is forked mode using/downloaded the distro
It can work because you download a SNAPSHOT of jetty-home or use one already here locally but it really depends on it.
Try running: mvn clean install -pl :jetty-maven-plugin -am with an empty repository.
There was a problem hiding this comment.
I can see that jetty-home doesn't build before jetty-maven-plugin, but I really cannot make it fail, even with a new <version>!
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
olamy
requested changes
Nov 16, 2022
jetty-maven-plugin/pom.xml
Outdated
| @@ -252,120 +252,6 @@ | |||
| <artifactId>jetty-slf4j-impl</artifactId> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
nope it depends on it.
see comment here #8898 (comment)
There was a problem hiding this comment.
Yet the build is green without it present.
There was a problem hiding this comment.
With this present, we get ...
[ERROR] [ERROR] The projects in the reactor contain a cyclic reference: Edge between
'Vertex{label='org.eclipse.jetty:javadoc:10.0.13-SNAPSHOT'}' and
'Vertex{label='org.eclipse.jetty:jetty-maven-plugin:10.0.13-SNAPSHOT'}' introduces to cycle in the graph
org.eclipse.jetty:jetty-maven-plugin:10.0.13-SNAPSHOT -->
org.eclipse.jetty:jetty-home:10.0.13-SNAPSHOT -->
org.eclipse.jetty:javadoc:10.0.13-SNAPSHOT -->
org.eclipse.jetty:jetty-maven-plugin:10.0.13-SNAPSHOT @
[ERROR] The projects in the reactor contain a cyclic reference: Edge between
'Vertex{label='org.eclipse.jetty:javadoc:10.0.13-SNAPSHOT'}' and
'Vertex{label='org.eclipse.jetty:jetty-maven-plugin:10.0.13-SNAPSHOT'}' introduces to cycle in the graph
org.eclipse.jetty:jetty-maven-plugin:10.0.13-SNAPSHOT -->
org.eclipse.jetty:jetty-home:10.0.13-SNAPSHOT -->
org.eclipse.jetty:javadoc:10.0.13-SNAPSHOT -->
org.eclipse.jetty:jetty-maven-plugin:10.0.13-SNAPSHOT -> [Help 1]
Perhaps we should remove jetty-maven-plugin from the javadoc?
Signed-off-by: Joakim Erdfelt <[email protected]>
olamy
approved these changes
Nov 17, 2022
|
this cause #10312 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experiment to see if a
jetty-home-<ver>-with-docs.zipcan be done, and makes sense.Signed-off-by: Joakim Erdfelt [email protected]