Fix traversal bug on extraction of bad jar/zip files during jetty-start #8688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joakim Erdfelt <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -198,7 +198,14 @@ | |||
| continue; | |||
| } | |||
|
|
|||
| Path destFile = destination.resolve(entry.getName()); | |||
| String entryName = entry.getName(); | |||
Check failure
Code scanning / CodeQL
Arbitrary file write during archive extraction ("Zip Slip")
olamy
approved these changes
Oct 5, 2022
sbordet
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jetty-start extraction of zip/jar files doesn't take into account traversal bugs in entries found in zip/jar files.
This PR fixes this for the jetty-start use case.
We already have similar protections in place for
JarResourceandSelectiveJarResourcein jetty proper.Signed-off-by: Joakim Erdfelt [email protected]