Allow to pass instances of ClientConfig and Config to Hazelcast data store factory #8600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…store factory This increases flexibility when configuring it programmatically. Patterns such as HazelcastSessionDataStoreFactory f = new HazelcastSessionDataStoreFactory(); f.setOnlyClient(true); f.setClientConfig(ClientConfig.load()); or HazelcastSessionDataStoreFactory f = new HazelcastSessionDataStoreFactory(); f.setServerConfig(Config.load()); can then be used to configure Hazelcast according to standard Hazelcast locations if needed.
|
@Vlatombe thanks for the contribution. |
|
I signed it with the email address matching the commit, but my Eclipse.org account was associated with another email address (which I changed). However the check still doesn't detect it. |
jglick
previously approved these changes
Sep 20, 2022
...cast/src/main/java/org/eclipse/jetty/hazelcast/session/HazelcastSessionDataStoreFactory.java
Outdated
Show resolved
Hide resolved
...cast/src/main/java/org/eclipse/jetty/hazelcast/session/HazelcastSessionDataStoreFactory.java
Outdated
Show resolved
Hide resolved
...cast/src/main/java/org/eclipse/jetty/hazelcast/session/HazelcastSessionDataStoreFactory.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jesse Glick <[email protected]>
olamy
approved these changes
Sep 21, 2022
no worries. there might be some caching in the Eclipse infra for validation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases flexibility when configuring it programmatically.
Patterns such as
or
can then be used to configure Hazelcast according to standard Hazelcast locations if needed.