Issue #8540, add classifier for jetty-10.0.x #8541
Conversation
MoonLord-LM
changed the title
| @@ -210,6 +210,7 @@ | |||
| <dependency> | |||
| <groupId>org.eclipse.jetty</groupId> | |||
| <artifactId>infinispan-remote</artifactId> | |||
| <classifier>config</classifier> | |||
There was a problem hiding this comment.
Depending on the config classifier (only meaningful to jetty-home) in a bom is just super odd, and feels wrong.
Why not just have <type>pom</type> instead?
There was a problem hiding this comment.
Yes, I agree, <type>pom</type> is better.
There was a problem hiding this comment.
@olamy can you think of any maven technical reason for not just using <type>pom</type> instead?
There was a problem hiding this comment.
the bom is mostly made (e.g only useful) for embedded users.
So TBH I don't even understand why we have <artifactId>infinispan-remote</artifactId> in the bom. This module contains no code but only configuration files.
So except the config jar which contains the jetty configuration module files it's a totally useless artifact :)
Either we remove it from the bom or we "expose" the only useless artifact which is the config but frankly I even don't understand why :)
wdy? Remove the entry from the bom?
There was a problem hiding this comment.
Remove the entry from the bom?
I'd vote +1 for this approach.
fix：#8540