Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #8216 - OpenID logout #8224

Closed
wants to merge 1 commit into from
Closed

Issue #8216 - OpenID logout #8224

wants to merge 1 commit into from

Conversation

keller-j
Copy link
Contributor

provide logoutto OpenIdAuthenticator via end_session_endpoint information retrieved from OpenIdConfiguration

@keller-j
Copy link
Contributor Author

NOTE: this is just a sample implementation of logout functionality. Constructors were just copied and extended with new attributes. Also not quite sure whether it is correct to send Authentication.SEND_CONTINUE to response for logout redirection:
https://github.com/keller-j/jetty.project/blob/5282ca37ef7a81789b3c1d0a41854259898bce96/jetty-openid/src/main/java/org/eclipse/jetty/security/openid/OpenIdAuthenticator.java#L608

Furthermore, also an option to redirect to end_session_endpoint with id_token_hint parameter set without supplying the redirectAfterLogout would be possible:
https://github.com/keller-j/jetty.project/blob/5282ca37ef7a81789b3c1d0a41854259898bce96/jetty-openid/src/main/java/org/eclipse/jetty/security/openid/OpenIdAuthenticator.java#L596

@keller-j keller-j mentioned this pull request Jun 29, 2022
Closed
@keller-j keller-j changed the title Issue #8216 Issue #8216 - OpenID logout Jun 29, 2022
@lachlan-roberts lachlan-roberts deleted the branch jetty:jetty-10.0.x-8216-openid-logout July 4, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keller-j @lachlan-roberts