Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #8170 - fix WebSocket close over HTTP/2 #8176

Merged
merged 2 commits into from
Jun 29, 2022
Merged

Issue #8170 - fix WebSocket close over HTTP/2 #8176

merged 2 commits into from
Jun 29, 2022

Conversation

lachlan-roberts
Copy link
Contributor

closes #8170

@lachlan-roberts lachlan-roberts requested a review from sbordet June 17, 2022 05:32
sbordet
sbordet requested changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be more verbose on commit messages, for other to follow why the code changes fix the issue.

...tp2/http2-server/src/main/java/org/eclipse/jetty/http2/server/ServerHTTP2StreamEndPoint.java Outdated Show resolved Hide resolved
@lachlan-roberts lachlan-roberts requested a review from sbordet June 17, 2022 07:56
@lachlan-roberts lachlan-roberts merged commit 8e0ccad into jetty-10.0.x Jun 29, 2022
@lachlan-roberts lachlan-roberts deleted the jetty-10.0.x-8170-WebSocketHttp2Close branch June 29, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbordet sbordet sbordet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WebSockets closed abruptly when using HTTP/2
2 participants
@lachlan-roberts @sbordet