Use static exceptions for closing websocket flushers and in ContentProducer #8155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts
requested review from
gregw,
sbordet and
lorban
and removed request for
gregw
lachlan-roberts
commented
Jun 10, 2022
| // ======================================================================== | ||
| // | ||
|
|
||
| package org.eclipse.jetty.websocket.core.exception; |
There was a problem hiding this comment.
Not sure if this should be here or in an internal implementation package.
gregw
requested changes
Jun 10, 2022
| * meaning calling {@link #addSuppressed(Throwable)} has no effect. | ||
| * This means instances of {@link SentinelWebSocketCloseException} are suitable to be kept as static fields. | ||
| */ | ||
| public class SentinelWebSocketCloseException extends Exception |
There was a problem hiding this comment.
As @lorban suggested, perhaps create a util class called StaticException that forces the false,true args of the super constructor.
Signed-off-by: Lachlan Roberts <[email protected]>
lorban
previously approved these changes
Jun 10, 2022
Signed-off-by: Ludovic Orban <[email protected]>
lorban
changed the title
|
Combined here the changes of #8135 as they're pretty trivial. |
gregw
previously approved these changes
Jun 11, 2022
jetty-util/src/main/java/org/eclipse/jetty/util/StaticException.java
Outdated
Show resolved
Hide resolved
sbordet
requested changes
Jun 12, 2022
jetty-util/src/main/java/org/eclipse/jetty/util/StaticException.java
Outdated
Show resolved
Hide resolved
jetty-server/src/main/java/org/eclipse/jetty/server/AsyncContentProducer.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ludovic Orban <[email protected]>
sbordet
requested changes
Jun 13, 2022
jetty-util/src/main/java/org/eclipse/jetty/util/StaticException.java
Outdated
Show resolved
Hide resolved
…efault Signed-off-by: Ludovic Orban <[email protected]>
sbordet
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lachlan Roberts [email protected]