-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #7935 - Review HTTP/2 error handling #7938
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now returning error handling code as a Runnable. Signed-off-by: Simone Bordet <[email protected]>
joakime
reviewed
Apr 29, 2022
jetty-http2/http2-server/src/test/java/org/eclipse/jetty/http2/server/BadURITest.java
Show resolved
Hide resolved
Updates after review. Signed-off-by: Simone Bordet <[email protected]>
joakime
approved these changes
May 1, 2022
gregw
approved these changes
May 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm re running the CI to see if the failure was a flake.
Other than that... LGTM
lorban
approved these changes
May 3, 2022
joakime
pushed a commit
that referenced
this pull request
May 11, 2022
Now returning error handling code as a Runnable. Updates after review. Signed-off-by: Simone Bordet <[email protected]> Signed-off-by: Joakim Erdfelt <[email protected]>
joakime
added a commit
that referenced
this pull request
May 11, 2022
Now returning error handling code as a Runnable. Updates after review. Co-authored-by: Simone Bordet <[email protected]> Signed-off-by: Joakim Erdfelt <[email protected]>
51 tasks
Merged to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now returning error handling code as a Runnable.
Signed-off-by: Simone Bordet [email protected]