Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7774 - Flaky Test: DataDemandTest.testBlockingReadInADifferent… #7776

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

sbordet
Copy link
Contributor

@sbordet sbordet commented Mar 24, 2022

…Thread().

Do not try to release the network buffer after having notified onDataAvailable()
because it can be in a race with the application trying to read data and also
trying to release the network buffer.

Signed-off-by: Simone Bordet [email protected]

…Thread().

Do not try to release the network buffer after having notified onDataAvailable()
because it can be in a race with the application trying to read data and also
trying to release the network buffer.

Signed-off-by: Simone Bordet <[email protected]>
@sbordet sbordet requested review from joakime and lorban March 24, 2022 17:07
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad we have a testcase for this.

Copy link
Contributor

@lorban lorban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbordet sbordet merged commit 40e7d6a into jetty-10.0.x Mar 25, 2022
@sbordet sbordet linked an issue Mar 25, 2022 that may be closed by this pull request
@sbordet sbordet deleted the jetty-10.0.x-7774-flaky-datademandtest branch March 25, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky Test : DataDemandTest.testBlockingReadInADifferentThread()
3 participants