Issue #7677 Exclude findbugs jsr305 jar from plugin #7682
Conversation
Signed-off-by: Jan Bartel <[email protected]>
|
We need an IT test for #7677 and this proposed PR. |
|
@joakime I don't really think that's strictly necessary: we don't need to test the maven |
there is something I don't understand because |
I would expect an IT test that ensures that our jetty-maven-plugin configuration does not pollute the classpath of a typical webapp unduly. I can easily see someone later adding a new dependency which introduces a transitive dependency that will break their deployments. Since our WebAppClassloader prevents replacing |
Marking it as |
it only means it will not be in the plugin classloader (using a forked jetty run would probably not trigger such issue). |
There was a problem hiding this comment.
not something perfect as we may exclude a lot more.
but it fix the OP issue and btw maven core will not change the behaviour soon :) (would break so many plugins..)
started a branch jetty-10.0.x-limit-maven-plugin-classloader but some issues with ServiceLoader
|
@olamy we have historically excluded maven classes from the webapp classpath by setting them up as server classes: https://github.com/eclipse/jetty.project/blob/jetty-10.0.x/jetty-maven-plugin/src/main/java/org/eclipse/jetty/maven/plugin/MavenWebInfConfiguration.java#L37 But, because this is Having to explicitly exclude packages or jars from the maven classpath is inherently fragile, and I'd prefer there was another way, but that allowed people to add |
oh that's good!!! even better. |
|
@janbartel I can add an IT test for the current case with this jsr. if you are happy my tomorrow :) |
Signed-off-by: Olivier Lamy <[email protected]>
|
@janbartel sorry for delay I was in the middle of water and mud those last days :) |
Signed-off-by: Olivier Lamy <[email protected]>
| @@ -61,6 +61,7 @@ public void getContentResponse() | |||
| } | |||
| String contentCheck = System.getProperty("contentCheck"); | |||
| String pathToCheck = System.getProperty("pathToCheck"); | |||
| System.out.println("contentCheck: " + contentCheck); | |||
There was a problem hiding this comment.
this class has few more.
And you will see them only when using m-invoker-p in debug mode or streamLogs which is not the case per default but only when debugging or when an IT test fail.
|
I have verified that the jsr jar is not present any more in the dependency tree of the |
Related to #7677.
Exclude findbugs jsr305 jar from maven core dependency.