-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add used but non declared dependencies and fix some scope #7626
add used but non declared dependencies and fix some scope #7626
Conversation
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments in code
@@ -395,6 +395,12 @@ | |||
<groupId>org.eclipse.jetty</groupId> | |||
<artifactId>jetty-jspc-maven-plugin</artifactId> | |||
<scope>provided</scope> | |||
<exclusions> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't going to help with #7677, as it's not the javax.annotation
jar that is the problem, it is the findbugs jsr305
jar that is the issue.
</dependency> | ||
<dependency> | ||
<groupId>org.apache.maven</groupId> | ||
<artifactId>maven-core</artifactId> | ||
<scope>provided</scope> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will have to add an exclusion for findbugs jsr305
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read this change as not exposing maven-core / findbugs jsr305 on the plugin classpath.
Perhaps we should add a new it
test for this, something that can replicate the report in #7677 and then prove out that this PR will fix things?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should not expose transitive dependencies of maven-core because provided
.
Yup I will have a look to add an IT.
Signed-off-by: Olivier Lamy [email protected]