simplify pom by using simple property rather than xml fragment #7580
Conversation
| @@ -10,6 +10,11 @@ | |||
| <artifactId>http3-tests</artifactId> | |||
| <name>Jetty :: HTTP3 :: Tests</name> | |||
|
|
|||
| <properties> | |||
There was a problem hiding this comment.
@sbordet I assume we should not deploy those tests as part of the release and was a mistake? or I am wrong?
There was a problem hiding this comment.
This module will only produce a test jar (no sources), so it won't be deployed anyway, right?
Ah, I see it deployed an empty jar 😒
So yes let's skip deploy for this module.
There was a problem hiding this comment.
after digging a bit the jar is not empty as it included some content we put in target/classes as part of the build such: generated MANIFEST.MF, LICENSE and NOTICE.txt
| <configuration> | ||
| <!-- must not deploy --> | ||
| <skip>false</skip> | ||
| </configuration> |
There was a problem hiding this comment.
I have to say I was confused here and not sure what to believe the comment or the code. :)
There was a problem hiding this comment.
I think it should be the same as the other osgi test projects ;)
| @@ -10,6 +10,11 @@ | |||
| <artifactId>http3-tests</artifactId> | |||
| <name>Jetty :: HTTP3 :: Tests</name> | |||
|
|
|||
| <properties> | |||
There was a problem hiding this comment.
This module will only produce a test jar (no sources), so it won't be deployed anyway, right?
Ah, I see it deployed an empty jar 😒
So yes let's skip deploy for this module.
| <configuration> | ||
| <!-- must not deploy --> | ||
| <skip>false</skip> | ||
| </configuration> |
There was a problem hiding this comment.
I think it should be the same as the other osgi test projects ;)
| <artifactId>maven-deploy-plugin</artifactId> | ||
| <configuration> | ||
| <!-- No point deploying jmh project --> | ||
| <skip>true</skip> |
There was a problem hiding this comment.
Needs the property defined? Or is that covered by the toplevel tests/pom.xml properties?
There was a problem hiding this comment.
correct. properties are inherited.
|
@olamy this one needs merge conflicts fixed |
|
@olamy nudge, needs merge. |
|
@janbartel oh yes I definitely forgot this old PR. thanks for the ping :) |
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
olamy
force-pushed
the
jetty-10.0.x-simplify-poms
branch
from
1b703ae to
f8dfdcd
Compare
Signed-off-by: Olivier Lamy [email protected]