Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid NPE when the websocket session is not created #7293

Closed
wants to merge 1 commit into from
Closed

Avoid NPE when the websocket session is not created #7293

wants to merge 1 commit into from

Conversation

azurvii
Copy link

@azurvii azurvii commented Dec 16, 2021

No description provided.

@azurvii
Copy link
Author

azurvii commented Dec 16, 2021

I could not make the eclipsefdn/eca check happy.

I logged in via the Details link and signed / accepted / OK'ed the ECA, and clicked Revalidate. The check is still off. It seems the anonymized email address reported by github is not matching the email address of my eclipse login. I have no intent to change my github setting.

If this change is deemed worthy, some one who could submit a checks-passing PR please help to take this forward, and possibly for other branches as well (e.g. 10.x, etc.).

Thanks.

@janbartel janbartel changed the title Avoid NPE when the session is not created Avoid NPE when the websocket session is not created Dec 16, 2021
@lachlan-roberts
Copy link
Contributor

@azurvii if you don't want to fix your ECA I can just open a new PR with this change for you.
This change will need to instead been done in the 10.0.x branch so it can be merged forward to 11.0.x.

@lachlan-roberts
Copy link
Contributor

Replaced by PR #7294.

@azurvii azurvii deleted the jetty-11.0.x branch December 16, 2021 09:02
@azurvii azurvii restored the jetty-11.0.x branch December 16, 2021 09:08
@joakime
Copy link
Contributor

joakime commented Dec 16, 2021

I could not make the eclipsefdn/eca check happy.

It looks like you submitted this via the github UI, as the From on the commit 7541ad4
Shows <github-user-id>@users.noreply.github.com.

It is not possible for a noreply user from github.com to have a signed ECA.

That commit also lacks the Signed-Off-By signature on the commit that the command line git -s adds, this is a requirement to satisfy the https://en.wikipedia.org/wiki/Developer_Certificate_of_Origin portion of the ECA check.

Using the gihub UI to created edits for submitted PRs doesn't convey the necessary legal handover stating "I did this", in the eyes of the Eclipse Legal.

@azurvii
Copy link
Author

azurvii commented Dec 16, 2021

Thanks @lachlan-roberts for moving this forward, and including the guard for remote as well.

Thanks @joakime for the explanation and pointers. I'll take a look at them. I did use the github UI, but I'd still prefer the github email if I were to use git.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants