Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #7111 - Add support to deprecate jetty-home modules. #7125

Merged
merged 2 commits into from
Dec 2, 2021

Conversation

sbordet
Copy link
Contributor

@sbordet sbordet commented Nov 16, 2021

Signed-off-by: Simone Bordet [email protected]

@sbordet sbordet requested a review from joakime November 16, 2021 16:06
@janbartel
Copy link
Contributor

janbartel commented Nov 19, 2021

@sbordet If someone forgets to add deprecated to the [tags] in the .mod file, is the module still listed for --list-modules, but without any indication it is deprecated?

joakime
joakime previously approved these changes Nov 29, 2021
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it.

@sbordet sbordet force-pushed the jetty-10.0.x-7111-deprecated-modules branch from 2929027 to ddf34ee Compare December 1, 2021 14:03
Updates after review.
Now if a module is deprecated, the list of enabled modules reports it.

Signed-off-by: Simone Bordet <[email protected]>
@sbordet
Copy link
Contributor Author

sbordet commented Dec 1, 2021

@janbartel I have addressed your concern. Now the list of enabled modules reports if a module is deprecated.
Best if it also has a tag, so all deprecated modules can be grouped together by --list-modules.

@sbordet sbordet linked an issue Dec 1, 2021 that may be closed by this pull request
@sbordet sbordet requested a review from joakime December 1, 2021 16:29
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sbordet sbordet merged commit 1ea012a into jetty-10.0.x Dec 2, 2021
@sbordet sbordet deleted the jetty-10.0.x-7111-deprecated-modules branch December 2, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to deprecate jetty-home modules
3 participants