Issue #7059 - prevent an internal NPE in AllowedResourceAliasChecker doStart (9.4) #7081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…doStart Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
joakime
requested changes
Nov 5, 2021
jetty-server/src/main/java/org/eclipse/jetty/server/AllowedResourceAliasChecker.java
Outdated
Show resolved
Hide resolved
jetty-server/src/main/java/org/eclipse/jetty/server/SymlinkAllowedResourceAliasChecker.java
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <[email protected]>
gregw
reviewed
Nov 10, 2021
jetty-server/src/main/java/org/eclipse/jetty/server/AllowedResourceAliasChecker.java
Show resolved
Hide resolved
gregw
previously approved these changes
Nov 10, 2021
…ve been added. Signed-off-by: Lachlan Roberts <[email protected]>
|
I have added changes suggested by @joakime. This introduces a behaviour change. The following code: ContextHandler context = new ContextHandler();
context.setResourceBase(...);
context.addAliasCheck(customAliasCheck);
context.start();Previously resulted in |
Signed-off-by: Lachlan Roberts <[email protected]>
joakime
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #7059
Backport of changes from PR #7076 to
9.4.xbranch.