Cherry pick update to infinispan 11.0.11 back to jetty-9.4.x(#6766) #6889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Issue #6687 Update to infinispan 11.0.11 Signed-off-by: Jan Bartel <[email protected]> * fix upperbound dependency * use infinispan bom Signed-off-by: Olivier Lamy <[email protected]> Co-authored-by: Olivier Lamy <[email protected]>
joakime
reviewed
Sep 22, 2021
| <groupId>org.jboss.threads</groupId> | ||
| <artifactId>jboss-threads</artifactId> | ||
| <version>3.1.0.Final</version> | ||
| </dependency> |
There was a problem hiding this comment.
The dependencies in 9.4.x are sorted alphabetically.
(Soon the 10.0.x deps will be too)
…87-update-infinispan
olamy
previously approved these changes
Oct 6, 2021
| <optional>true</optional> | ||
| <exclusions> | ||
| <exclusion> |
There was a problem hiding this comment.
nit but we usually have 2 spaces indent in pom
| @@ -108,6 +115,12 @@ | |||
| <artifactId>infinispan-core</artifactId> | |||
| <version>${infinispan.version}</version> | |||
| <scope>test</scope> | |||
| <exclusions> | |||
| <exclusion> | |||
There was a problem hiding this comment.
nit but we usually have 2 spaces indent in pom
| .withRegEx(".*Infinispan Server.*started in.*\\s")) | ||
| .withExposedPorts(4712, 4713, 8088, 8089, 8443, 9990, 9993, 11211, 11222, 11223, 11224) | ||
| .withLogConsumer(new Slf4jLogConsumer(INFINISPAN_LOG)); | ||
| .withEnv("USER", "theuser") |
There was a problem hiding this comment.
doh I can't believe checkstyle doesn't complain about removed/missing indent here.
olamy
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.