Issue #6205 - Fix issues with OpenID redirecting to wrong URI (#6211) #6245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbordet
previously approved these changes
May 12, 2021
There was a problem hiding this comment.
@lachlan-roberts just a small nit to fix before merging, otherwise LGTM.
| private static final int MAX_SIZE = 64; | ||
|
|
||
| @Override | ||
| protected boolean removeEldestEntry(Map.Entry eldest) |
There was a problem hiding this comment.
Missing type parameters, should be Map.Entry<String, UriRedirectInfo>
lachlan-roberts
force-pushed
the
jetty-9.4.x-6205-OpenID
branch
from
0e0558f
to
9d37dbd
Compare
sbordet
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #6205
Merge of the changes from PR #6211 back to
9.4.xbranch.