Issue #5304 HTTP2 HostHeader #5307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated HostHeaderCustomizer to actually add the Host header, either from values passed in the custructor or from the getServerName and getServerPort methods. The HttpURI is no longer updated. Signed-off-by: Greg Wilkins <[email protected]>
joakime
reviewed
Sep 21, 2020
jetty-server/src/main/java/org/eclipse/jetty/server/HostHeaderCustomizer.java
Show resolved
Hide resolved
joakime
requested changes
Sep 21, 2020
jetty-server/src/main/java/org/eclipse/jetty/server/HostHeaderCustomizer.java
Show resolved
Hide resolved
+ Found and fixed bug in HttpFields + Added port normalization support to HttpScheme + added test Signed-off-by: Greg Wilkins <[email protected]>
Signed-off-by: Greg Wilkins <[email protected]>
+ refixed bug in HttpFields Signed-off-by: Greg Wilkins <[email protected]>
+ still fixing HttpFields bug Signed-off-by: Greg Wilkins <[email protected]>
joakime
requested changes
Sep 22, 2020
jetty-server/src/main/java/org/eclipse/jetty/server/HostHeaderCustomizer.java
Show resolved
Hide resolved
jetty-server/src/main/java/org/eclipse/jetty/server/HostHeaderCustomizer.java
Show resolved
Hide resolved
updates from review
|
@joakime nudge |
joakime
requested changes
Sep 22, 2020
jetty-server/src/main/java/org/eclipse/jetty/server/HostHeaderCustomizer.java
Show resolved
Hide resolved
|
@joakim, it's not accidentally mutable. The style we mostly use is that the setter decides if it wants the mutable or immutable reference. So in this case request will call asImutable on the passed HttpField. The idea is that the callee decides and the caller can never make the request fields mutable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5304
Updated HostHeaderCustomizer to actually add the Host header, either from values passed in the custructor or from the getServerName and getServerPort methods.
The HttpURI is no longer updated.
Signed-off-by: Greg Wilkins [email protected]