-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #4996 - Regularlize logging #5167
Issue #4996 - Regularlize logging #5167
Conversation
Signed-off-by: Jan Bartel <[email protected]>
…4996-regularlize-logging
…4996-regularlize-logging Signed-off-by: Jan Bartel <[email protected]>
Signed-off-by: Jan Bartel <[email protected]>
Signed-off-by: Jan Bartel <[email protected]>
Signed-off-by: Jan Bartel <[email protected]>
Signed-off-by: Jan Bartel <[email protected]>
Signed-off-by: Jan Bartel <[email protected]>
…4996-regularlize-logging
Signed-off-by: Jan Bartel <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
jetty-http2/http2-hpack/src/main/java/org/eclipse/jetty/http2/hpack/HpackEncoder.java
Outdated
Show resolved
Hide resolved
jetty-server/src/main/java/org/eclipse/jetty/server/PushBuilderImpl.java
Show resolved
Hide resolved
jetty-server/src/main/java/org/eclipse/jetty/server/handler/ResourceHandler.java
Show resolved
Hide resolved
@janbartel I added another commit a79b1c8 to address the remaining logging parameter mismatches, could you give them a once over? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can just change the metadata param in the HpackEncoder, I'm good.
jetty-http2/http2-hpack/src/main/java/org/eclipse/jetty/http2/hpack/HpackEncoder.java
Show resolved
Hide resolved
jetty-server/src/main/java/org/eclipse/jetty/server/handler/ResourceHandler.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of niggles, but otherwise LGTM
jetty-documentation/src/main/asciidoc/contribution-guide/3-source.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: Jan Bartel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…4996-regularlize-logging
Closes #4996
Bumper clean up of logging statements.
LOG.isDebugEnabled()
LOG.warn
,LOG.debug
,LOG.info
statements that have args something like("blah " + foo, throwable)
to be("blah {}", foo, throwable)
as the logging system supports the interpretation of the last arg always as a throwable.