Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #4996 - Regularlize logging #5167

Merged
merged 14 commits into from
Aug 24, 2020

Conversation

janbartel
Copy link
Contributor

Closes #4996

Bumper clean up of logging statements.

  • fixed up a few logging statements that were missing parameter subtsitutions
  • simplified some logging statements that were unnecessarily doing multiple LOG statements just to ouptut a bunch of different parameters
  • guarded more LOG.debug with LOG.isDebugEnabled()
  • changed LOG.warn, LOG.debug, LOG.info statements that have args something like ("blah " + foo, throwable) to be ("blah {}", foo, throwable) as the logging system supports the interpretation of the last arg always as a throwable.
  • modified a few logging statements to conform to the recently agreed logging standards
  • added the logging standards to the contribution documentation

@janbartel janbartel requested review from joakime, gregw and sbordet August 18, 2020 11:05
Signed-off-by: Jan Bartel <[email protected]>
@joakime joakime changed the title Jetty 10.0.x 4996 regularlize logging Issue #4996 - Regularlize logging Aug 20, 2020
@joakime
Copy link
Contributor

joakime commented Aug 20, 2020

@janbartel I added another commit a79b1c8 to address the remaining logging parameter mismatches, could you give them a once over?
I'm good with the changes you've already made.

Copy link
Contributor Author

@janbartel janbartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can just change the metadata param in the HpackEncoder, I'm good.

Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of niggles, but otherwise LGTM

Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janbartel janbartel merged commit 77779ed into jetty-10.0.x Aug 24, 2020
@janbartel janbartel deleted the jetty-10.0.x-4996-regularlize-logging branch August 24, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning log printed when debug is enabled in AbstractLifecycle.java
4 participants