Jetty 9.4.x 4976 httpclient fix null network buffer #5010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llel which can happen when the parser returns handled=true Signed-off-by: Ludovic Orban <[email protected]>
Reworked handling of asynchronous content by immediately exiting HttpReceiverOverHTTP.process(), so that there is no race with other threads that have been scheduled to resume the processing. The call to HttpReceiver.dispose() that could be triggered by an asynchronous failure is now performed either by the failing thread (if the HttpReceiver is not processing) or by an I/O thread (if the HttpReceiver is processing) similarly to what happens when terminating the response. The content decoding has been reworked to perform the required state changes similarly to what non-decoded content is doing, as this was completely lacking before (it was actually a side bug that is now fixed). Signed-off-by: Simone Bordet <[email protected]>
Updates after review. Signed-off-by: Simone Bordet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.