Issue #4890 - Do not index large HTTP2 Fields #4927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When choosing a strategy to encode a HTTP2 field, do not use indexed if the field is larger than the dynamic table. Signed-off-by: Greg Wilkins <[email protected]>
Fixed checkstyle in test Signed-off-by: Greg Wilkins <[email protected]>
lorban
approved these changes
Jun 1, 2020
sbordet
approved these changes
Jun 1, 2020
jetty-http2/http2-hpack/src/main/java/org/eclipse/jetty/http2/hpack/HpackEncoder.java
Outdated
Show resolved
Hide resolved
jetty-http2/http2-hpack/src/main/java/org/eclipse/jetty/http2/hpack/HpackEncoder.java
Outdated
Show resolved
Hide resolved
Only index 0 content-length Signed-off-by: Greg Wilkins <[email protected]>
Fixed comments Signed-off-by: Greg Wilkins <[email protected]>
Don't parse int Signed-off-by: Greg Wilkins <[email protected]>
sbordet
approved these changes
Jun 1, 2020
joakime
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4890. Do not index encode fields larger than the dynamic table.