Issue #4691 - use static methods with javadoc to get MethodHandle lookups #4694
Conversation
Signed-off-by: Lachlan Roberts <[email protected]>
| @@ -374,7 +374,7 @@ private void assertBasicTypeNotRegistered(byte basicWebSocketType, Object messag | |||
| try | |||
| { | |||
| // TODO: move methodhandle lookup to container? | |||
| MethodHandles.Lookup lookup = MethodHandles.publicLookup(); | |||
| MethodHandles.Lookup lookup = JavaxWebSocketFrameHandlerFactory.getServerMethodHandleLookup(); | |||
There was a problem hiding this comment.
Do you still need the TODO above?
There was a problem hiding this comment.
I think we can remove it, I don't know why we would want to do this in the container, it seems better to contain the MethodHandle stuff in the FrameHandler.
| @@ -432,7 +432,7 @@ else if (String.class.isAssignableFrom(clazz)) | |||
| try | |||
| { | |||
| // TODO: move MethodHandle lookup to container? | |||
| MethodHandles.Lookup lookup = MethodHandles.publicLookup(); | |||
| MethodHandles.Lookup lookup = JavaxWebSocketFrameHandlerFactory.getServerMethodHandleLookup(); | |||
| /** | ||
| * <p> | ||
| * Gives a {@link MethodHandles.Lookup} instance to be used to find methods in server classes. | ||
| * For lookups on application classes use {@link #getApplicationMethodHandleLookup(Class)} ()} instead. |
There was a problem hiding this comment.
There is an additional ()} in the javadoc.
| * to server classes we need to use and will give access permissions to private methods as well. | ||
| * </p> | ||
| * | ||
| * @return |
There was a problem hiding this comment.
Missing description of what it returns.
| * to server classes we need to use and will give access permissions to private methods as well. | ||
| * </p> | ||
| * | ||
| * @return |
There was a problem hiding this comment.
To avoid duplicating these javadocs, I would rather @see JavaxWebSocketFrameHandlerFactory#getServerMethodHandleLookup().
So that if we improve the javadocs, we only do it in one place.
Check that we can actually do this @see because it will reference a class in a different module that is not dependent on this one.
There was a problem hiding this comment.
This can't be done, I think they will have to be duplicated.
Symbol 'org.eclipse.jetty.websocket.javax.common.JavaxWebSocketFrameHandlerFactory' is inaccessible from here.
| * </p> | ||
| * @param lookupClass the desired lookup class for the new lookup object. | ||
| * @return a lookup object to be used to find methods on the lookupClass. | ||
| */ |
Signed-off-by: Lachlan Roberts <[email protected]>
lachlan-roberts
deleted the
jetty-10.0.x-4691-consistent_methodhandles_lookup
branch
Issue #4691
Method handle lookups for websocket are now all created from static methods on both the Jetty and Javax FrameHandlerFactory. Two static methods are given, one for looking up methods on server classes and one for looking up methods on application classes.
These methods now have javadoc to describe the reasons why these specific MethodHandle lookups are the correct ones to use for the given situation.