Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #4620 - support alt PrintStream in StdErrAppender properly #4689

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Mar 21, 2020

  • The console-capture jetty module will reset System.err to
    RollingFileOutputStream. But that's too late, as StdErrAppender
    has already grabbed and is holding onto the System.err from
    earlier, which means it is not writing to the new System.err.

Signed-off-by: Joakim Erdfelt [email protected]

+ The console-capture jetty module will reset System.err to
  RollingFileOutputStream.  But that's too late, as StdErrAppender
  has already grabbed and is holding onto the System.err from
  earlier, which means it is not writing to the new System.err.

Signed-off-by: Joakim Erdfelt <[email protected]>
@joakime joakime requested a review from sbordet March 21, 2020 18:52
@joakime joakime self-assigned this Mar 21, 2020
@joakime joakime added the Bug For general bugs on Jetty side label Mar 21, 2020
@joakime joakime linked an issue Mar 21, 2020 that may be closed by this pull request
Copy link
Contributor

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

@sbordet sbordet self-requested a review March 23, 2020 11:41
@joakime joakime merged commit dfc2568 into jetty-10.0.x Mar 23, 2020
@joakime joakime deleted the jetty-10.0.x-4620-stderr-console-capture branch March 23, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using console-capture with StdErrLog results in empty log file
2 participants