Issue #4572 - Replace Jetty Logging with slf4j logging (part 2 of 3) #4643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made HTTP2SessionContainer implement Graceful, so that it can be found in the component hierarchy and can shutdown all sessions. Modified HTTP2ServerSession to reject requests if already closed/shutdown. Implemented shutdown in HTTP2Session. Signed-off-by: Simone Bordet <[email protected]>
Updates after review. Signed-off-by: Simone Bordet <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Message reader now validates UTF8 Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Remove ContextListeners from the destroy list when removed. Signed-off-by: Greg Wilkins <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
* Fixes #4577 IPAccessHandler in context Fixes and tests #4577 IPAccessHandler in context by using target instead of pathInfo for path matching. Signed-off-by: Greg Wilkins <[email protected]> * Tests #4577 IPAccessHandler target Updates from review. Signed-off-by: Greg Wilkins <[email protected]> * Issue #4577 IpAccessHandler NPE Match on full URI path rather than target. Signed-off-by: Greg Wilkins <[email protected]>
* Issue #4550 XmlConfiguration argument matching Improve argument matching by: + rejecting obviously non matches (with allowance for unboxing) + sorting methods so that derived arguments are tried before more generic (eg String before Object) Signed-off-by: Greg Wilkins <[email protected]> * Issue #4550 XmlConfiguration argument matching Improve argument matching by: + can unbox from any Number to any Number Signed-off-by: Greg Wilkins <[email protected]> * Issue #4550 Do not check the assignability of the arguments. Instead rely on the order of the methods. Signed-off-by: Greg Wilkins <[email protected]> * Issue #4550 unbox test no longer required Signed-off-by: Greg Wilkins <[email protected]> * Issue #4550 Simplified test Signed-off-by: Greg Wilkins <[email protected]> * Issue #4550 Cleanup comparator Signed-off-by: Greg Wilkins <[email protected]> * Issue #4550 Cleanup comparator Signed-off-by: Greg Wilkins <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
…atNow Issue #4606 - fixing formatTick use of `now`
Signed-off-by: Greg Wilkins <[email protected]>
* Fix NPE in HouseKeeper.stopScavenging Signed-off-by: Hirotaka Ikoma <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
Co-authored-by: Lachlan <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
…er' into jetty-10.0.x-4598-InetAccessHandler
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Greg Wilkins <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
+ Also adding note to jetty-util classes that are used by jetty-start Signed-off-by: Joakim Erdfelt <[email protected]>
…O (not DEBUG) Signed-off-by: Joakim Erdfelt <[email protected]>
Issue #4571 - websocket aggregating text and binary MessageSinks
…Writer Issue #4538 - rework of websocket message reader and writers
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
…xception Issue #4645 - better error message for empty X-Forwarded-Port value
* Refactor CrossOriginFilter Signed-off-by: Denny Abraham Cheriyan <[email protected]> * Fix checkstyle violation Signed-off-by: Denny Abraham Cheriyan <[email protected]>
* Refactor CrossOriginFilter Signed-off-by: Denny Abraham Cheriyan <[email protected]> * Fix checkstyle violation Signed-off-by: Denny Abraham Cheriyan <[email protected]>
Signed-off-by: Simone Bordet <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
Signed-off-by: Joakim Erdfelt <[email protected]>
…4572-slf4j-logging-part2 Signed-off-by: Joakim Erdfelt <[email protected]>
gregw
approved these changes
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is part 2 (of 3) is based off of branch
jetty-10.0.x-4572-new-slf4j-logger-impl(which is part 1 of 3)See Part 1 on PR #4601
slf4j-apito jetty-utiljetty-slf4j-implas solid dependency in jetty-utilorg.eclipse.jetty.util.log.*classes (and test cases)org.eclipse.jetty.util.log.classesrequires org.slf4j;to module-info.java classes on maven projects that are actually using logging.org.eclipse.jetty.util.log.Log.class=<impl>from jetty-logging.propertiestest-realm.xmluse of Log classes to print warninglogging-jettyis the default for providerloggingStacklessLoggingto neworg.eclipse.jetty.logginglocation.