Jetty 9.4.x 4331 async close complete - take 2 #4398
Conversation
Added test harness to reproduce unready completing write. Fixed test by not closing output prior to becoming READY Signed-off-by: Greg Wilkins <[email protected]>
Test harness to reproduce unready when closing/completing. Signed-off-by: Greg Wilkins <[email protected]>
test both PENDING and UNREADY Signed-off-by: Greg Wilkins <[email protected]>
test cleanups Signed-off-by: Greg Wilkins <[email protected]>
Cleanups of write Signed-off-by: Greg Wilkins <[email protected]>
…31-asyncCloseComplete2
Signed-off-by: Greg Wilkins <[email protected]>
Work in progress Signed-off-by: Greg Wilkins <[email protected]>
|
@lachlan-roberts and @sbordet as before... some review of work in progress appreciated so I don't bark up the wrong mixed metaphor |
Added async close to HttpWriter and ResponseWriter Always use async close, with blocker if necessary. Signed-off-by: Greg Wilkins <[email protected]>
Working async close complete! Signed-off-by: Greg Wilkins <[email protected]>
invert test as we can now call complete when not ready! Signed-off-by: Greg Wilkins <[email protected]>
fixed transition to ERROR state Signed-off-by: Greg Wilkins <[email protected]>
async close after onError Signed-off-by: Greg Wilkins <[email protected]>
minor cleanups Signed-off-by: Greg Wilkins <[email protected]>
jetty-server/src/main/java/org/eclipse/jetty/server/HttpOutput.java
Outdated
Show resolved
Hide resolved
| continue; | ||
| if (LOG.isDebugEnabled()) | ||
| LOG.debug("onWritePossible"); | ||
| _writeListener.onWritePossible(); |
There was a problem hiding this comment.
If we are in state CLOSED or CLOSING we will now call onWritePossible() here?
There was a problem hiding this comment.
I think we want to do that.... if we have got to UNREADY state we should call owp even if we are closed.
But I'm only 95% sure of that...
There are strange situations... like if we are closed then isReady should return true (else another dispatch is scheduled)...
but if we sent content length and then the very last write of the content congests for a while - what should isReady return? true because it knows that the connection will be closed once the write is complete, or false thus causing an OWP callback with a closed output! I think the later is correct... but we need to review carefully!
Fix for proxy tests Signed-off-by: Greg Wilkins <[email protected]>
Fix write loop to handle clear of p=0,l=0 rather than p=l Signed-off-by: Greg Wilkins <[email protected]>
|
@sbordet can you try this with cometd and the reactive API to check it doesn't break async behaviours? |
Removed old close on all content mechanism Cleanups and some more TODOs Signed-off-by: Greg Wilkins <[email protected]>
|
I'm closing in favour of #4409 |
take two at a fix for #4331