Issue #4376 Async Content Complete #4377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added test harness to reproduce unready completing write. Fixed test by not closing output prior to becoming READY Signed-off-by: Greg Wilkins <[email protected]>
gregw
added
the
Sponsored
This was referenced Nov 28, 2019
ERROR state still needs to be closed! Signed-off-by: Greg Wilkins <[email protected]>
close after last blocking write Signed-off-by: Greg Wilkins <[email protected]>
If completion has to do a flush, then we need a call to closed to avoid leaking buffers. Signed-off-by: Greg Wilkins <[email protected]>
sbordet
approved these changes
Dec 2, 2019
| { | ||
| AsyncContext context = request.startAsync(); | ||
| ServletOutputStream out = response.getOutputStream(); | ||
| out.setWriteListener(new WriteListener() { |
There was a problem hiding this comment.
Brace at end of line. You are being assimilated.
This whole file needs a formatting pass.
Reformat Signed-off-by: Greg Wilkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test harness to reproduce unready completing write for #4376
Fixed test by not closing output prior to becoming READY
Signed-off-by: Greg Wilkins [email protected]