Issue #4323 Ensure QoSFilter handles IllegalStateException #4372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Bartel <[email protected]>
janbartel
deleted the
jetty-9.4.x-4323-qosfilter-handle-illegalstateexception
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #4323
Ensure that an IllegalStateException thrown by an async context that is being resumed after being suspended is caught, resulting in the loop to find a request to resume continuing.
Also move the release of the semaphore to higher in the handling code to ensure that the release always occurs, regardless of subsequent failures.
Also, to simplify the handling in doFilter, do not do a re-dispatch on an async context that had failed with onTimeout: instead, send an error response directly from the QoSAsyncListener.onTimeout() method.