Create start.d/*.ini for [ini-template] modules #12593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Will always create ini file if the module is enabled directly or via transitive dependency AND it has a [ini-template] section.
sbordet
requested changes
Nov 27, 2024
jetty-core/jetty-start/src/main/java/org/eclipse/jetty/start/BaseBuilder.java
Outdated
Show resolved
Hide resolved
…created for transitive dependencies. Signed-off-by: Simone Bordet <[email protected]>
|
@joakime I have updated the documentation, please review (even if it's your PR). |
sbordet
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As as have many modules that now have
[ini-template], it's getting confusing for users that want to configure something, but they didn't directly declare the module in the--add-modulecommand line.A prime example is if they enable
--add-module=httpsthehttpsmodule is enabled, but it has no[ini-template]and the dependent modulesslalso isn't created instart.d/ssl.inias it wasn't specified.With the changes in this PR, the above example would also have the
start.d/ssl.inicreated.