Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12578 pretty print getParameterMap #12585

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

gregw
Copy link
Contributor

@gregw gregw commented Nov 26, 2024

Fix #12578 pretty print getParameterMap
Added test for parameters

Fix #12578 pretty print getParameterMap
Added test for parameters
joakime
joakime previously approved these changes Nov 26, 2024
Fix #12578 pretty print getParameterMap
checkstyle
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a TypeUtil.toString(Map<String,String> map) that does this? and have it used in both places?

Fix #12578 pretty print getParameterMap
Added TypeUtil method
Copy link
Contributor

@janbartel janbartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@gregw gregw dismissed joakime’s stale review November 29, 2024 20:32

changes made, others reviewed

@gregw gregw merged commit a8aec30 into jetty-12.0.x Nov 29, 2024
10 checks passed
@gregw gregw deleted the fix/12578/prettyPrintParameters branch November 29, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

HttpServletRequest.getParameterMap - UnmodifiableMap does not wrap a jetty MultiMap
5 participants