Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align embedded and XML defaults for HttpConfiguration #12555

Merged
merged 5 commits into from
Nov 29, 2024

Conversation

gregw
Copy link
Contributor

@gregw gregw commented Nov 21, 2024

Fix #11947 by aligning embedded and XML HttpConfiguration defaults

Fix #11947 by aligning embedded and XML HttpConfiguration defaults
Fix #11947 by aligning embedded and XML HttpConfiguration defaults
Revert most changes
Copy link
Contributor

@lachlan-roberts lachlan-roberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the test failures are not a flake, the SiweTest was expecting the full URI in the redirect but now only gets the relative redirect.

Fix #11947 by aligning embedded and XML HttpConfiguration defaults
Fixed SIWE
@gregw
Copy link
Contributor Author

gregw commented Nov 23, 2024

I think the test failures are not a flake, the SiweTest was expecting the full URI in the redirect but now only gets the relative redirect.

Fixed. Also those tests had bad ee10 packages. Have you blogged about this feature yet?

@gregw gregw requested a review from sbordet November 28, 2024 00:38
@gregw gregw merged commit 8ca1c05 into jetty-12.1.x Nov 29, 2024
10 checks passed
@gregw gregw deleted the fix/11947/alignEmbeddedAndXmlDefaults branch November 29, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

6 participants