Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve module deprecation #12547

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Improve module deprecation #12547

merged 1 commit into from
Nov 19, 2024

Conversation

gregw
Copy link
Contributor

@gregw gregw commented Nov 18, 2024

Improved module deprecation messages
used on more modules

Improved messages
used on more modules
@gregw gregw requested a review from sbordet November 18, 2024 23:20
@gregw gregw linked an issue Nov 18, 2024 that may be closed by this pull request
@gregw gregw requested a review from olamy November 19, 2024 00:48
Copy link
Contributor

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart the line swap.

gzip
cross-origin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were in alphabetical order, is there a reason to swap lines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just put the compression and gzip together as they are in other modules

@gregw gregw merged commit 3443cb4 into jetty-12.1.x Nov 19, 2024
10 checks passed
@gregw gregw deleted the fix/12540/moduleDeprecation branch November 19, 2024 23:03
olamy pushed a commit that referenced this pull request Nov 20, 2024
Improved messages
used on more modules
olamy pushed a commit that referenced this pull request Nov 20, 2024
Improved messages
used on more modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Jetty module deprecation
3 participants