Issue #12241 Restore SameSite config as session cookie comment. #12263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joakime
requested changes
Sep 12, 2024
jetty-ee9/jetty-ee9-nested/src/main/java/org/eclipse/jetty/ee9/nested/SessionHandler.java
Outdated
Show resolved
Hide resolved
| if (comment.contains(SAME_SITE_NONE_COMMENT)) | ||
| _sessionManager.setSameSite(HttpCookie.SameSite.NONE); | ||
| if (comment.contains(PARTITIONED_COMMENT)) | ||
| _sessionManager.setPartitioned(true); |
There was a problem hiding this comment.
Use the techniques in HttpCookieFacade here.
Bonus is that you can even get a clean comment field too.
joakime
requested changes
Sep 12, 2024
Comment on lines
624
to
628
| protected static final String SAME_SITE_COMMENT = "__SAME_SITE_"; | ||
| protected static final String SAME_SITE_NONE_COMMENT = SAME_SITE_COMMENT + "NONE__"; | ||
| protected static final String SAME_SITE_LAX_COMMENT = SAME_SITE_COMMENT + "LAX__"; | ||
| protected static final String SAME_SITE_STRICT_COMMENT = SAME_SITE_COMMENT + "STRICT__"; | ||
| protected static final String PARTITIONED_COMMENT = "__PARTITIONED__"; |
There was a problem hiding this comment.
These constants are no longer needed here.
joakime
approved these changes
Sep 13, 2024
janbartel
deleted the
jetty-12.0.x-12241-restore-samesite-in-cookie-comment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User reported not being able set
SameSitevia old jetty session cookie comment mechanism. This PR restores that, but only for ee8 and ee9.