Fixes #12122 - NPE in HttpReceiver.responseContentAvailable(). #12123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now also the HttpReceiver.responseContentAvailable() is serialized, so that the access to `this.contentSource` is serialized with failure, and protected by a call to `exchange.isResponseCompleteOrTerminated()`. Before, it was possible that a thread failed the response, nulling out `this.contentSource`, while another thread was just about to call `responseContentAvailable()` -- this was the case for HTTP/2 in particular, where content is notified asynchronously, rather than being created by a call to `ContentSource.read()`. Signed-off-by: Simone Bordet <[email protected]>
|
@sbordet can you stage artifacts for me to test? |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
I can confirm that this change fixes the issue that we've seen in our benchmarks while running with HTTP/2 |
lorban
requested changes
Aug 6, 2024
| * This method directly invokes the demand callback, assuming the caller | ||
| * is already serialized with other events. | ||
| */ | ||
| protected void responseContentAvailable() |
There was a problem hiding this comment.
Shouldn't this method be private?
There was a problem hiding this comment.
No, it is called from other places when it's known that there is no need to serialize.
lorban
previously approved these changes
Aug 7, 2024
Added test case. Signed-off-by: Simone Bordet <[email protected]>
lorban
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now also the HttpReceiver.responseContentAvailable() is serialized, so that the access to
this.contentSourceis serialized with failure, and protected by a call toexchange.isResponseCompleteOrTerminated().Before, it was possible that a thread failed the response, nulling out
this.contentSource, while another thread was just about to callresponseContentAvailable()-- this was the case for HTTP/2 in particular, where content is notified asynchronously, rather than being created by a call toContentSource.read().