Do not use HttpStream.Wrapper in SizeLimitHandler #11051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
gregw
previously approved these changes
Dec 13, 2023
Signed-off-by: Lachlan Roberts <[email protected]>
sbordet
requested changes
Dec 13, 2023
There was a problem hiding this comment.
Looks good, but:
- Please fix the class javadocs, as there are many typos.
- Please add documentation about this Handler in
server-http-handler-use.adoc. You can find sections that talk about other utility handlers Jetty provides (such as GzipHandler, etc.), and you can take one of those sections as example for theSizeLimitHandler. At least add in the docs what's in the class javadocs.
gregw
previously approved these changes
Dec 13, 2023
lachlan-roberts
added
the
Sponsored
Signed-off-by: Simone Bordet <[email protected]>
|
@lachlan-roberts I have updated documentation and javadocs. |
sbordet
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using an HttpStream.wrapper will bypass the
GzipHandlerwhich wraps the request and response.So we should also wrap the request and response in
SizeLimitHandler.This also fixes a bug where the read/write counts are not reset for each request.