WebSocketUpgradeHandler should not require ContextHandler #10768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
|
@lachlan-roberts can you explain why you need this? I'm not against it, just curious about why. |
|
I don't specifically need this and I did not create an issue for it. I just saw these tests and didn't think the We don't require a |
sbordet
requested changes
Oct 24, 2023
...-server/src/main/java/org/eclipse/jetty/websocket/core/server/WebSocketServerComponents.java
Outdated
Show resolved
Hide resolved
...-server/src/main/java/org/eclipse/jetty/websocket/core/server/WebSocketServerComponents.java
Outdated
Show resolved
Hide resolved
...-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/ServerWebSocketContainer.java
Outdated
Show resolved
Hide resolved
...t-jetty-server/src/main/java/org/eclipse/jetty/websocket/server/WebSocketUpgradeHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <[email protected]>
…er'. Signed-off-by: Simone Bordet <[email protected]>
… the WebSocketUpgradeHandler with only the Server, to allow dynamic configuration of WebSocket endpoints. Signed-off-by: Simone Bordet <[email protected]>
sbordet
previously approved these changes
Nov 20, 2023
There was a problem hiding this comment.
@lachlan-roberts I have updated WebSocketUpgradeHandler to expose the ServerWebSocketContainer as attribute also when created with only the Server.
LGTM now.
…er'. Signed-off-by: Simone Bordet <[email protected]>
sbordet
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebSocketUpgradeHandlershould not be required to be wrapped inside aContextHandler