Issue #10463 Fix lastModified header when using HttpServletResponseWrapper #10556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joakime
reviewed
Sep 20, 2023
| @@ -1402,7 +1402,7 @@ else if (contentLength > NO_CONTENT_LENGTH) | |||
|
|
|||
| public static void putHeaders(HttpServletResponse response, HttpContent content, long contentLength, boolean etag) | |||
| { | |||
| long lml = content.getLastModified().getLongValue(); | |||
There was a problem hiding this comment.
The bug seems to be in HttpContent.getLastModified(), why not fix it there?
There was a problem hiding this comment.
The bug isn't in HttpContent.getLastModified(), which is a HttpField representing a stringified Date value. If you look at the same code in jetty-10/11 etc, this is how we handle this case. See https://github.com/eclipse/jetty.project/blob/jetty-10.0.x/jetty-server/src/main/java/org/eclipse/jetty/server/Response.java#L1450
joakime
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10463