-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added WebSocket migration documentation, pointing to existing WebSock… #10542
Conversation
…et documentation. Signed-off-by: Simone Bordet <[email protected]>
…ocs'. Signed-off-by: Simone Bordet <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just niggles
...on/jetty-documentation/src/main/asciidoc/programming-guide/migration/migration-11-to-12.adoc
Outdated
Show resolved
Hide resolved
The Jetty 12 WebSocket APIs are now fully asynchronous, so the Jetty 11 `SuspendToken` class has been removed in favor of an explicit (or automatic) demand mechanism in Jetty 12 (for more information, refer to xref:pg-websocket-endpoints-demand[this section]). | ||
|
||
The various Jetty 11 `WebSocket*Listener` interfaces have been replaced by a single interface in Jetty 12, `Session.Listener.AutoDemanding` (for more information, refer to xref:pg-websocket-endpoints-listener[this section]). | ||
|
||
The Jetty 11 `RemoteEndpoint` APIs have been merged into the `Session` APIs in Jetty 12. | ||
|
||
The Jetty 11 `WriteCallback` class has been renamed to just `Callback` in Jetty 12, because it is now also used when receiving binary data. | ||
|
||
On the server-side, the Jetty WebSocket APIs have been made independent of the Servlet APIs. | ||
|
||
Jetty 11 `JettyWebSocketServerContainer` has been replaced by `ServerWebSocketContainer` in Jetty 12, with similar APIs (for more information, refer to xref:pg-server-websocket-jetty[this section]). | ||
|
||
On the client-side the `WebSocketClient` APIs are practically unchanged, as most of the changes come from the `HttpClient` changes described above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reads as a bullet list, so it might be more readable as such rather than as paragraphs.
...on/jetty-documentation/src/main/asciidoc/programming-guide/migration/migration-11-to-12.adoc
Show resolved
Hide resolved
Signed-off-by: Simone Bordet <[email protected]>
…et documentation.