Introduced CompletableResponseListener #10502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nseListener that uses better APIs based on CompletableFuture. Deprecated FutureResponseListener and replaced its usages. Updated documentation. Added tests for zipped request content. Signed-off-by: Simone Bordet <[email protected]>
Signed-off-by: Simone Bordet <[email protected]>
gregw
approved these changes
Sep 14, 2023
Comment on lines
21
to
22
| * <p>A {@link BufferingResponseListener} that takes care of sending | ||
| * the request, returning a {@link CompletableFuture} that is completed |
There was a problem hiding this comment.
Suggested change
| * <p>A {@link BufferingResponseListener} that takes care of sending | |
| * the request, returning a {@link CompletableFuture} that is completed | |
| * <p>A {@link BufferingResponseListener} that sends a | |
| * {@link Request} and returns a {@link CompletableFuture} that is completed |
| /** | ||
| * <p>A {@link BufferingResponseListener} that takes care of sending | ||
| * the request, returning a {@link CompletableFuture} that is completed | ||
| * when the request/response is completed.</p> |
There was a problem hiding this comment.
Suggested change
| * when the request/response is completed.</p> | |
| * when the {@link #onComplete(Result)} event method is called.</p> |
Signed-off-by: Simone Bordet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CompletableResponseListener replaces FutureResponseListener, using better APIs based on CompletableFuture.
Deprecated FutureResponseListener and replaced its usages.
Updated documentation.
Added tests for zipped request content.