Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #10086 - Revisiting ProxyConfiguration.getProxies() #10116

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,18 @@ public class ProxyConfiguration
private final List<Proxy> proxies = new BlockingArrayQueue<>();

/**
* <p>Returns the list of proxies added to this configuration.</p>
* <p>This method is deprecated because it has historically been
* used to add/remove proxies directly to/from the returned list,
* but this has now been replaced by {@link #addProxy(Proxy)} and
* {@link #removeProxy(Proxy)} instead.</p>
* <p>In the future, this method will return an unmodifiable
* list of proxies just for querying purposes.</p>
joakime marked this conversation as resolved.
Show resolved Hide resolved
*
* @deprecated use {@link #addProxy(Proxy)} and {@link #removeProxy(Proxy)} instead
* @return the forward proxies to use
*/
@Deprecated(forRemoval = true)
@Deprecated
public List<Proxy> getProxies()
{
return proxies;
Expand Down