Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve JPMS testing for websocket in Jetty 12 #9396

Closed
lachlan-roberts opened this issue Feb 17, 2023 · 0 comments
Closed

Improve JPMS testing for websocket in Jetty 12 #9396

lachlan-roberts opened this issue Feb 17, 2023 · 0 comments
Assignees
@lachlan-roberts
Labels
High Priority

Comments

@lachlan-roberts
Copy link
Contributor

I added --jpms to some of the websocket tests in DistributionTests and got some failures. These should be investigated and extra tests should be added to confirm that this works.

Also add a test for the JakartaWebSocketShutdownContainer which is an internal class and not in a package exported with JPMS but is exposed for the service loader, and does a protectAndExpose in the JakartaWebSocketConfiguration class.
@lachlan-roberts lachlan-roberts added the Bug For general bugs on Jetty side label Feb 17, 2023
@lachlan-roberts lachlan-roberts self-assigned this Feb 17, 2023
@lachlan-roberts lachlan-roberts added Jetty 12 and removed Bug For general bugs on Jetty side labels Feb 17, 2023
lachlan-roberts added a commit that referenced this issue Jun 15, 2023
@lachlan-roberts
Issue #9396 - fixes to resolve WebSocket JPMS warnings
b0923b2 
Signed-off-by: Lachlan Roberts <[email protected]>
@lachlan-roberts lachlan-roberts mentioned this issue Jun 15, 2023
Merged
lachlan-roberts added a commit that referenced this issue Jun 19, 2023
@lachlan-roberts
Issue #9396 - Improve JPMS testing for websocket in Jetty 12
cf78881 
Signed-off-by: Lachlan Roberts <[email protected]>
@gregw gregw moved this to 🏗 In progress in Jetty 12.0.0.beta3 Jun 21, 2023
@lachlan-roberts lachlan-roberts moved this from 🏗 In progress to 👀 In review in Jetty 12.0.0.beta3 Jun 22, 2023
lachlan-roberts added a commit that referenced this issue Jul 3, 2023
@lachlan-roberts
Merge pull request #9915 from eclipse/jetty-12.0.x-9396-websocket-jpm…
643c11c 
…s-review

Issue #9396 - fixes to resolve WebSocket JPMS warnings
@lachlan-roberts lachlan-roberts moved this from 👀 In review to ✅ Done in Jetty 12.0.0.beta3 Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachlan-roberts lachlan-roberts

Labels
High Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joakime @lachlan-roberts