You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description LowResourceMonitor.getReasons returns a hard-coded string, namely the string representation of the LowResourceCheck that is low on resources. It should contain the detailed low-resource reason instead, which would be more useful.
For example, it should return Server low on threads: x, idleThreads: y vs the current Check if the ThreadPool from monitored connectors are lowOnThreads and if all connections number is higher than the allowed maxConnection.
Proposed diffs:
diff --git a/jetty-server/src/main/java/org/eclipse/jetty/server/LowResourceMonitor.java b/jetty-server/src/main/java/org/eclipse/jetty/server/LowResourceMonitor.java
index 07c7ab427d..7529404b17 100644
--- a/jetty-server/src/main/java/org/eclipse/jetty/server/LowResourceMonitor.java
+++ b/jetty-server/src/main/java/org/eclipse/jetty/server/LowResourceMonitor.java
@@ -280,7 +280,7 @@ public class LowResourceMonitor extends ContainerLifeCycle
{
if (lowResourceCheck.isLowOnResources())
{
- reasons = lowResourceCheck.toString();
+ reasons = lowResourceCheck.getReason();
break;
}
}
If needed, the LowResourceCheck string representation could be appended to the reason.
The text was updated successfully, but these errors were encountered:
Jetty version(s)
10.0.13
Description
LowResourceMonitor.getReasons
returns a hard-coded string, namely the string representation of theLowResourceCheck
that is low on resources. It should contain the detailed low-resource reason instead, which would be more useful.For example, it should return
Server low on threads: x, idleThreads: y
vs the currentCheck if the ThreadPool from monitored connectors are lowOnThreads and if all connections number is higher than the allowed maxConnection
.Proposed diffs:
If needed, the LowResourceCheck string representation could be appended to the reason.
The text was updated successfully, but these errors were encountered: