Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named arguments do not work in jetty-openid.xml #7545

Closed
lachlan-roberts opened this issue Feb 8, 2022 · 0 comments
Closed

Named arguments do not work in jetty-openid.xml #7545

lachlan-roberts opened this issue Feb 8, 2022 · 0 comments
Assignees
Labels
Bug For general bugs on Jetty side

Comments

@lachlan-roberts
Copy link
Contributor

Jetty version(s)
10.0.8 & 11.0.8

Description

In jetty-openid.xml the OpenIdConfiguration is constructed using named arguments:

<New id="OpenIdConfiguration" class="org.eclipse.jetty.security.openid.OpenIdConfiguration">
  <Arg name="issuer"><Property name="jetty.openid.provider" deprecated="jetty.openid.openIdProvider"/></Arg>
  <Arg name="authorizationEndpoint"><Property name="jetty.openid.provider.authorizationEndpoint"/></Arg>
  <Arg name="tokenEndpoint"><Property name="jetty.openid.provider.tokenEndpoint"/></Arg>
  <Arg name="clientId"><Property name="jetty.openid.clientId"/></Arg>
  <Arg name="clientSecret"><Property name="jetty.openid.clientSecret"/></Arg>
  <Arg name="authMethod"><Property name="jetty.openid.authMethod" default="client_secret_post"/></Arg>
  <Arg name="httpClient"><Ref refid="HttpClient"/></Arg>

These do not have corresponding annotations in the OpenIdConfiguration constructor, so this XML file fails with an error that it cannot find the constructor.

@lachlan-roberts lachlan-roberts added the Bug For general bugs on Jetty side label Feb 8, 2022
@lachlan-roberts lachlan-roberts self-assigned this Feb 8, 2022
lachlan-roberts added a commit that referenced this issue Feb 8, 2022
lachlan-roberts added a commit that referenced this issue Feb 8, 2022
lachlan-roberts added a commit that referenced this issue Feb 8, 2022
Signed-off-by: Lachlan Roberts <[email protected]>
joakime pushed a commit that referenced this issue Feb 25, 2022
…est XML

Signed-off-by: Lachlan Roberts <[email protected]>
(cherry picked from commit 58c230e)
joakime pushed a commit that referenced this issue Feb 25, 2022
…nstructor

Signed-off-by: Lachlan Roberts <[email protected]>
(cherry picked from commit e1d149f)
joakime pushed a commit that referenced this issue Feb 25, 2022
Signed-off-by: Lachlan Roberts <[email protected]>
(cherry picked from commit 5fe999c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
None yet
Development

No branches or pull requests

1 participant