Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputStreamResponseListener should have a read timeout #7259

Open
sbordet opened this issue Dec 10, 2021 · 3 comments
Open

InputStreamResponseListener should have a read timeout #7259

sbordet opened this issue Dec 10, 2021 · 3 comments
Labels
Enhancement Stale For auto-closed stale issues and pull requests

Comments

@sbordet
Copy link
Contributor

sbordet commented Dec 10, 2021

Target Jetty version(s)
9.4.x

Enhancement Description
Class InputStreamResponseListener is currently using an infinite wait in case a read blocks.

This is sub-optimal because there is a risk that the caller thread waits forever, even if the class is designed to wake up blocked reads in case of errors, timeouts, close, etc.
sbordet added a commit that referenced this issue Dec 10, 2021
@sbordet
Fixes InputStreamResponseListener should have a read timeout #7259
aa8cb73 
Added constructor with read timeout parameter.
Updated implementation to honor the read timeout.
Added test case.

Signed-off-by: Simone Bordet <[email protected]>
@sbordet sbordet mentioned this issue Dec 10, 2021
Closed
@github-actions
Copy link

This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the Stale For auto-closed stale issues and pull requests label Dec 11, 2022
@sbordet sbordet removed the Stale For auto-closed stale issues and pull requests label Dec 12, 2022
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the Stale For auto-closed stale issues and pull requests label Dec 13, 2023
@sbordet sbordet removed the Stale For auto-closed stale issues and pull requests label Dec 15, 2023
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the Stale For auto-closed stale issues and pull requests label Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Stale For auto-closed stale issues and pull requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sbordet