Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise ContextHandler.isProtectedTarget #6305

Closed
gregw opened this issue May 20, 2021 · 0 comments · Fixed by #6306
Closed

Optimise ContextHandler.isProtectedTarget #6305

gregw opened this issue May 20, 2021 · 0 comments · Fixed by #6306
Assignees

Comments

@gregw
Copy link
Contributor

gregw commented May 20, 2021

The isProtectedTarget method is called on every new request. It's implementation could be optimised to save trillions of CPU cycles!, but we must get it right as it is a key protection.

@gregw gregw self-assigned this May 20, 2021
gregw added a commit that referenced this issue May 20, 2021
Fix #6305 Optimise isProtectedTarget by using case insensitive Index.

Signed-off-by: Greg Wilkins <[email protected]>
gregw added a commit that referenced this issue May 21, 2021
updates from review

Signed-off-by: Greg Wilkins <[email protected]>
gregw added a commit that referenced this issue May 21, 2021
updates from review

Signed-off-by: Greg Wilkins <[email protected]>
gregw added a commit that referenced this issue May 28, 2021
* Fix #6305 Optimise isProtectedTarget

Fix #6305 Optimise isProtectedTarget by using case insensitive Index.

Signed-off-by: Greg Wilkins <[email protected]>

* Fix #6305 Optimise isProtectedTarget

updates from review

Signed-off-by: Greg Wilkins <[email protected]>

* Fix #6305 Optimise isProtectedTarget

updates from review

Signed-off-by: Greg Wilkins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant