Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazily allocate HTTP2Stream data queue #6250

Closed
sbordet opened this issue May 10, 2021 · 0 comments · Fixed by #6252
Closed

Lazily allocate HTTP2Stream data queue #6250

sbordet opened this issue May 10, 2021 · 0 comments · Fixed by #6252
Assignees
@sbordet

Comments

@sbordet
Copy link
Contributor

sbordet commented May 10, 2021

Jetty version
10.0.x

Description
Most HTTP2Stream have no content, and allocating an ArrayDeque to never use it has proven to be an allocation hotspot.

Since it's always accessed inside a lock anyway, lazily allocate it.
@sbordet sbordet self-assigned this May 10, 2021
sbordet added a commit that referenced this issue May 10, 2021
@sbordet
Fixes #6250 - Lazily allocate HTTP2Stream data queue.
8c1a0c5 
Now the data queue is lazily allocated.

Signed-off-by: Simone Bordet <[email protected]>
sbordet added a commit that referenced this issue May 11, 2021
@sbordet
Fixes #6250 - Lazily allocate HTTP2Stream data queue.
df1f2e5 
Updates after review.

Signed-off-by: Simone Bordet <[email protected]>
@sbordet sbordet linked a pull request May 19, 2021 that will close this issue
Fixes #6250 - Lazily allocate HTTP2Stream data queue. #6252
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbordet sbordet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #6250 - Lazily allocate HTTP2Stream data queue. jetty/jetty.project
1 participant
@sbordet