Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include can set pathInContext #5779

Closed
gregw opened this issue Dec 9, 2020 · 0 comments · Fixed by #5780
Closed

Include can set pathInContext #5779

gregw opened this issue Dec 9, 2020 · 0 comments · Fixed by #5780
Assignees
@gregw
Labels
TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc)

Comments

@gregw
Copy link
Contributor

gregw commented Dec 9, 2020

Jetty version
10.0.0

Description

This TCK failure is due to the pathInContext being incorrectly set and then not reset for an include.
@gregw gregw self-assigned this Dec 9, 2020
@gregw gregw added the TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc) label Dec 9, 2020
gregw added a commit that referenced this issue Dec 9, 2020
@gregw
Fixes #5779 Include should not set pathInContext
d5e08cb 
Fixes #5779 by ensuring that ContextHandler does not set pathInContext for include.
@gregw gregw mentioned this issue Dec 9, 2020
Merged
gregw added a commit that referenced this issue Dec 11, 2020
@gregw
Fixes #5779 Include should not set pathInContext (#5780)
f17a5fb 
Fixes #5779 by ensuring that ContextHandler does not set pathInContext for include.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregw gregw

Labels
TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #5779 Include should not set pathInContext jetty/jetty.project
1 participant
@gregw